2,257
edits
Changes
Jump to navigation
Jump to search
no edit summary
Line 18:
Line 18:
* remap image uses older bit od ID to distinguish one remap type from another, while it should be a typed field
* use fixed32 and fixed64 where approiate instead of uint32 and uint64 https://developers.google.com/protocol-buffers/docs/proto
* use fixed32 and fixed64 where approiate instead of uint32 and uint64 https://developers.google.com/protocol-buffers/docs/proto
* flock's flag and type fields is actually too much for what is stored there
* flock's flag and type fields is actually too much for what is stored there
−* evenpoll's tfd ID field is always zero
* evenpoll's tfd ID field is always zero
* Images structure is not natural. Some contain pb entries of a same type, some have a header of one pb type and then an array of another type or some raw data.
* Images structure is not natural. Some contain pb entries of a same type, some have a header of one pb type and then an array of another type or some raw data.